Give Flutie some love#90
Merged
Merged
Conversation
Some dependencies were really outdated and couldn't be installed on the latest Ruby version. That prevented even the project setup without too much hassle. The simplest solution is to bump the minimum Rails version to the oldest version that can support Ruby 3.4. Rails 6.0 only supports Ruby < 6.0.0, so unfortunately (or perhaps fortunately) it had to go. In this process, some Rails versions refused to install because Ruby has been dropping some default gems that Rails didn't require on its own, or some Rails dependency stopped depending on some other gem that Rails actually depended on implicitly, and that broke Rails. Those gems are now added conditionally on the Appraisals file.
neilvcarvalho
force-pushed
the
nc-give-some-love
branch
from
3c51254 to
5d64b7a
Compare
Also configure GitHub workflows to keep the README and SECURITY files up-to-date.
neilvcarvalho
force-pushed
the
nc-give-some-love
branch
from
5d64b7a to
3eff967
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to fix a small bug in
flutieand couldn't even set up the project in my machine. Then I noticed there was so much more to do here, and got caught in a Hal fixing a light bulb situation:This PR does a lot of things:
You may want to refer to individual commits to understand those changes better. Still, other than the minimum versions bump, you can understand it all like a big "making flutie up-to-date with other open source projects" change.